Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode extra_params to handle spaces. #113

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Encode extra_params to handle spaces. #113

merged 1 commit into from
Dec 13, 2016

Conversation

miknight
Copy link
Contributor

For example, using get_all_monitors() with group_states including the state no data would result in a 400 error prior to this change.

@mknight-atl
Encode extra_params to handle spaces.
13444cf 
For example, using get_all_monitors() with 'group_states' including the state 'no data' would result in a 400 error prior to this change.
@degemer degemer added this to the 1.24.0 milestone Oct 19, 2016
@degemer
Copy link
Member

degemer commented Oct 19, 2016

Thank you for the fix @miknight !
I'll take some time to review and test it properly next week.

@degemer degemer self-assigned this Oct 19, 2016
@degemer
Copy link
Member

degemer commented Dec 13, 2016

Sorry for the delay and thanks again @miknight ! Merging, will be part of the next release.

@degemer degemer merged commit ca998bc into DataDog:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@degemer degemer

Labels
None yet
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@miknight @degemer @mknight-atl